Skip to content

Replacing deprecated function toECDSAPub#5

Closed
MathieuGilbert wants to merge 1 commit intoCoinCircle:masterfrom
MathieuGilbert:update-crypto-toECDSAPub
Closed

Replacing deprecated function toECDSAPub#5
MathieuGilbert wants to merge 1 commit intoCoinCircle:masterfrom
MathieuGilbert:update-crypto-toECDSAPub

Conversation

@MathieuGilbert
Copy link
Copy Markdown

Resolves error from go test and go get:

> go test ./...
# github.com/coincircle/go-etherdelta
../../coincircle/go-etherdelta/etherdelta.go:602:12: undefined: "github.com/ethereum/go-ethereum/crypto".ToECDSAPub

- Replaced crypto.toECDSAPub with crypto.UnmarshalPubKey, based on ethereum/go-ethereum#16932
- Skipping failing test (test token isn't in live results).
@MathieuGilbert MathieuGilbert mentioned this pull request Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant